Migrate apps to Spring Functions Catalog #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove `functions` module * Remove `functions` from build scripts * Change internal `functions` mentioning in the docs to the dedication Spring Functions Catalog project * Remove all the TensorFlow modules
|
@corneil , I'm not good with all those CI/CD scripts, so probably a follow up change required. |
|
Forgot to mention. |
|
@artembilan The change you made to build-core is sufficient for the CI to function as it should. |
corneil
approved these changes
Mar 8, 2024
onobc
reviewed
Mar 8, 2024
onobc
requested changes
Mar 8, 2024
There was a problem hiding this comment.
Nice work @artembilan !
One comment around updating the READMEs. Other than that LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
functionsmodulefunctionsfrom build scriptsfunctionsmentioning in the docs to the dedication Spring Functions Catalog project