Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for Incorrect Postgres SQL Query Generation for IN and NOT IN Filters #1186

Closed
wants to merge 3 commits into from
Closed

Fix for Incorrect Postgres SQL Query Generation for IN and NOT IN Filters #1186

wants to merge 3 commits into from

Conversation

muthuishere
Copy link
Contributor

Bug fix for Incorrect SQL Query Generation for IN and NOT IN Filter Expressions in PGVector Store

#1179

  • Added In & Not In Handlers
  • Created Integration Tests for it
  • Updated Unit Tests to adapt the in & not in filters

@sobychacko
Copy link
Contributor

@muthuishere PR looks good. Can you add your name as an author to the classes you changed?

@muthuishere
Copy link
Contributor Author

@muthuishere PR looks good. Can you add your name as an author to the classes you changed?

added

@markpollack
Copy link
Member

many thanks, merged in 6bd059a

@markpollack markpollack added this to the 1.0.0-M2 milestone Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-M2
Development

Successfully merging this pull request may close these issues.
3 participants
@muthuishere @sobychacko @markpollack