Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(onnx): add a note when the onnxruntime_gpu dependency is missing. #1192

Merged
merged 1 commit into from
Aug 11, 2024

Conversation

dongfeng3692
Copy link
Contributor

No description provided.

@tzolov
Copy link
Contributor

tzolov commented Aug 11, 2024

Thanks you @dongfeng3692
Valuable insight. I was wondering if we should add the onnxruntime_gpu dependency by default, but it appears that it is not supported on all platforms yet.

@tzolov tzolov added this to the 1.0.0-M2 milestone Aug 11, 2024
@tzolov tzolov self-assigned this Aug 11, 2024
@tzolov tzolov merged commit aeba9c2 into spring-projects:main Aug 11, 2024
1 check passed
@dongfeng3692
Copy link
Contributor Author

@tzolov
I do not recommend adding onnxruntime_gpu as a default dependency. Different versions of the dependency support different CUDA versions, and the onnxruntime_gpu package is large, for example, version 1.18.0 is 357 MB. Such a large dependency could cause inconvenience to users who do not use GPUs.
image

@tzolov
Copy link
Contributor

tzolov commented Aug 13, 2024

Thanks for the elaboration @dongfeng3692
Agree that it will be too heavy to add this deps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants