Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix streaming function call for MiniMax chat model #1276

Closed

Conversation

mxsl-gr
Copy link
Contributor

@mxsl-gr mxsl-gr commented Aug 26, 2024

this PR fixed streaming function call for MiniMax chat model

sometimes, the MiniMax stream mode function calls might get split, resulting in an empty tool call ID, which indicates that the previous call is not finished, this api design is quite strange.

For example, tool calls return like [{"id":"1","function":{"name":"a"}},{"id":"","function":{"arguments":"[1]"}}], need to be merged into [{"id":"1","name":"a","arguments":"[1]"}]

@markpollack
Copy link
Member

thanks, what a tricky business! merged in 8bfb25d

@markpollack markpollack added this to the 1.0.0-M3 milestone Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants