Optimization: remove redundant check on each vector operation #4597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: stroller <fujian1115@gmail.com>
| } | ||
| return; | ||
| } | ||
| if (!indexExists()) { |
There was a problem hiding this comment.
Given the indexExists() is called here as well, perhaps we can optimise this for reusability in the above logic to throw exception when index doesn't exist.
There was a problem hiding this comment.
I'd move line 339 higher up and reuse it here also, it will be called anyway
There was a problem hiding this comment.
@ilayaperumalg @deejay1 thanks for your review and comments. I just do one small refactor to simple the code.
PTAL
Thanks!
|
@jiafu1115 Thanks for the PR! |
Signed-off-by: stroller <fujian1115@gmail.com>
ilayaperumalg
approved these changes
Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each vector operation (such as
ElasticsearchVectorStore#doAdd）callsElasticsearchIndicesClient#existsvia an HTTP request to check whether the index exists. This redundant check wastes performance, so a small refactor was performed to eliminate it.