Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix BedrockAnthropic3ChatModel out of bounds exception #766

Closed
wants to merge 1 commit into from
Closed

Fix BedrockAnthropic3ChatModel out of bounds exception #766

wants to merge 1 commit into from

Conversation

maxjiang153
Copy link
Contributor

Fix BedrockAnthropic3ChatModel handle AnthropicChatResponse out of bounds exception when response content is empty.

see: #757

Fix BedrockAnthropic3ChatModel handle AnthropicChatResponse out of bo…
11223ae 
…unds exception when response content is empty.
@maxjiang153
Copy link
Contributor Author

re-implement with: #813

@maxjiang153 maxjiang153 closed this Jun 4, 2024
@markpollack
Copy link
Member

Fixed, please reopen if other issues are encounterd.

@markpollack markpollack reopened this Jul 22, 2024
@markpollack markpollack added this to the 1.0.0-M2 milestone Jul 22, 2024
@maxjiang153
Copy link
Contributor Author

Will this PR be considered individually or combined with #813?

@markpollack
Copy link
Member

markpollack commented Aug 20, 2024 •
edited
Loading

sorry, I thought I merged this. We very much appreciate the other PR, it is a huge help but also we need to really sit down and digest it all. So I will merge this now and #813 will be done in another step.

merged in 32a4652

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0-M2
Development

Successfully merging this pull request may close these issues.
2 participants
@maxjiang153 @markpollack