-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multimodality support on ChatClient with Azure OpenAI API #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution @bmoussaud !
I left few comments for code style alignments. Once those are resolved I will give it a try and merge it!
Als, please consider updating the multimodality docs page: https://docs.spring.io/spring-ai/reference/api/multimodality.html
You can add the Azure model to the list there.
Thank you again!
import com.azure.ai.openai.models.ChatCompletionsJsonResponseFormat; | ||
import com.azure.ai.openai.models.ChatCompletionsTextResponseFormat; | ||
import com.azure.ai.openai.models.ChatCompletionsResponseFormat; | ||
import com.azure.ai.openai.models.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -88,14 +66,14 @@ public class AzureOpenAiChatModel | |||
private final Logger logger = LoggerFactory.getLogger(getClass()); | |||
|
|||
/** | |||
* The configuration information for a chat completions request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of churning those lines?
|
||
import java.io.IOException; | ||
import java.net.URL; | ||
import java.util.*; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same , no wild card imports
fix import and add documentation restore the order of the declaration
Hi @bmoussaud, thanks for the contribution. |
rebased, squashed and merged at c9dd336 |
The
1.0.0-beta.8
supports multimodality only if the external resources are added to the request.This is what this PR add to the Azure Open AI provide.