Fix for ProjectMerger.mergeMavenPlugins Xml Declarations Issue #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects#217 Discovered while working on a project that was trying to merge some openapi plugin tooling. The ConversionUtil code was returning strings with xml declarations and that was breaking and not working as expectd in the openrewrite recipes that modify the pom's plugins * Added a Test for ConversionUtil to demonstrate existing behavior * Added Test for expected ConversionUtil output * Updated ConversionUtil to avoid returning dependencies with default dependency content * Updated MavenModificationTests with additional validation around merged/added plugins Signed-off-by: Jacob Danner <jacob.danner@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Fix for ProjectMerger.mergeMavenPlugins Issue
see: #217
Discovered while working on a project that was trying to merge some openapi plugin tooling. The ConversionUtil code was returning strings with xml declarations and that was breaking and not working as expectd in the openrewrite recipes that modify the pom's plugins