Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-247: Fix java.nio.ReadOnlyBufferException thrown by KclMessageDrivenChannelAdapter in batch mode #248

Merged
merged 1 commit into from
Nov 8, 2024
Merged

GH-247: Fix java.nio.ReadOnlyBufferException thrown by KclMessageDrivenChannelAdapter in batch mode #248

merged 1 commit into from
Nov 8, 2024

Conversation

kelseyh
Copy link
Contributor

@kelseyh kelseyh commented Nov 8, 2024

Fix for #247

Changes

  • Use BinaryUtils.copyAllBytes to fix java.nio.ReadOnlyBufferException thrown when processing batch records in KclMessageDrivenAdapter
  • Improve test time by more than a couple minutes by initialising the lease table

@kelseyh
spring-projectsGH-247: Fix java.nio.ReadOnlyBufferException thrown by…
bf0268c 
… KclMessageDrivenChannelAdapter in batch mode
@artembilan artembilan added this to the 3.0.9 milestone Nov 8, 2024
@artembilan artembilan added the bug label Nov 8, 2024
@artembilan artembilan merged commit adb66e4 into spring-projects:main Nov 8, 2024
1 check passed
@artembilan
Copy link
Member

This is great!
Thank you very much for the contribution; looking forward for more!

@artembilan artembilan removed the bug label Nov 8, 2024
@artembilan artembilan removed this from the 3.0.9 milestone Nov 8, 2024
@kelseyh
Copy link
Contributor Author

kelseyh commented Nov 12, 2024 •
edited
Loading

np :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kelseyh @artembilan