feat(dist):final scd touches #647
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxschmalenbach
changed the base branch from
main
to
feat(dist)/assign-ln-to-ied
| allEdits, | ||
| didApplyBayType ? { squash: true } : { title } | ||
| ) | ||
| } |
Collaborator
There was a problem hiding this comment.
this looks really complex, lets break this down into multiple functions with more descriptive names, so we know whats happening
| ): Element | null { | ||
| let functionElements: Element[] = [] | ||
|
|
||
| // EqFunctions are inside ConductingEquipment |
Collaborator
There was a problem hiding this comment.
this also looks really complex, perhaps break this down into smaller chunks?
tmenzel27
commented
Jan 30, 2026
Collaborator
Author
There was a problem hiding this comment.
i need to change this back to your version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒 Description
📷 Demo screen recording or Screenshots
📋 Checklist
You may remove tasks that do not make sense in this PR.
🔦 Useful commits
You can add specific commits which are worth taking a look into
❌ Link issue(s) to close - hint
closes #ISSUE_NUMBER