This repository was archived by the owner on Mar 11, 2025. It is now read-only.
feat: add GMP native token handler adapter#253
Closed
Conversation
lastperson
suggested changes
Jun 24, 2024
Contributor
lastperson
left a comment
There was a problem hiding this comment.
If native currencies are of the same value between the origin and destination, then perhaps we should have a single adapter implementation deployed on both chains to facilitate movement in both directions?
lastperson
suggested changes
Jun 25, 2024
lastperson
approved these changes
Jul 10, 2024
mpetrun5
reviewed
Jul 15, 2024
Collaborator
mpetrun5
left a comment
There was a problem hiding this comment.
The implementation is OK, though I would consider adapter implementations be part of another repo with them.
sygma-solidity IMO should only be for core solidity stuff.
Contributor
Author
|
Closing this as for the time being it will not be used in production |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds adapter for native token trasnfers via GMP.
Related Issue Or Context
Closes: #231
How Has This Been Tested? Testing details.
unit and e2e tests
Types of changes
Checklist: