SpritzBridgeReceiver #20
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,67 @@ | |||
| // SPDX-License-Identifier: UNLICENSED | |||
|
|
|||
| pragma solidity ^0.8.7; | |||
|
|
||
| pragma solidity ^0.8.7; | ||
|
|
||
| import "@openzeppelin/contracts/access/AccessControlEnumerable.sol"; |
There was a problem hiding this comment.
try openzeppelin-5, its aliased to the latest openzeppelin contracts which are better
| bytes32 public constant BRIDGE_ROLE = keccak256("BRIDGE_ROLE"); | ||
|
|
||
| // @dev Address of paraswap | ||
| address internal _target = 0xDEF171Fe48CF0115B1d80b88dc8eAB59176FEe57; |
There was a problem hiding this comment.
make these all contstants
| ) external payable onlyRole(BRIDGE_ROLE) { | ||
| require(amount <= IERC20(fromToken).balanceOf(address(this)), "Amount exceeds balance"); | ||
| IERC20(fromToken).safeApprove(_allowanceTarget, amount); | ||
| _target.call{ value: msg.value }(swapData); |
There was a problem hiding this comment.
(bool success, ) = _target.call{ value: msg.value }(swapData);
if (!success) {
assembly {
returndatacopy(0, 0, returndatasize())
revert(0, returndatasize())
}
}
| * @param to Target address | ||
| */ | ||
| function sweep(IERC20 token, address to) external onlyRole(BRIDGE_ROLE) { | ||
| token.transfer(to, token.balanceOf(address(this))); |
There was a problem hiding this comment.
safeTransfer, just because it can cause issues in some cases where the token doesn't conform properly
| require(amount <= IERC20(fromToken).balanceOf(address(this)), "Amount exceeds balance"); | ||
| IERC20(fromToken).safeApprove(_allowanceTarget, amount); | ||
| _target.call{ value: msg.value }(swapData); | ||
| IERC20(toToken).transfer(_circleReceiving, IERC20(toToken).balanceOf(address(this))); |
| * @param swapData Data for paraswap call | ||
| */ | ||
| function swapToken( | ||
| address fromToken, |
There was a problem hiding this comment.
you can cast this to IERC20 then you wont need to do it everywhere else
| // @dev Circle receiving address | ||
| address internal _circleReceiving = 0xb0E2D41a14494717f42Ffc6327F9D250b0ad32a8; | ||
|
|
||
| constructor(address bridgeRole) { |
There was a problem hiding this comment.
you can make the constructor payable to save some gas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.