SDK-2708 add tests

spryker-sdk · Oct 18, 2023 · dcd51c8 · dcd51c8
1 parent 0368f59
commit dcd51c8
Show file tree

Hide file tree

Showing 6 changed files with 255 additions and 79 deletions.
diff --git a/src/Builder/Creator/AbstractMethodCreator.php b/src/Builder/Creator/AbstractMethodCreator.php
@@ -12,8 +12,7 @@
 use PhpParser\BuilderFactory;
 use PhpParser\Node\Expr;
 use PhpParser\Node\Expr\ClassConstFetch;
-use SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface;
-use SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface;
+use SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface;
 use SprykerSdk\Integrator\Transfer\ClassInformationTransfer;
 
 class AbstractMethodCreator
@@ -24,46 +23,16 @@ class AbstractMethodCreator
     protected const SIMPLE_VARIABLE_SEMICOLON_COUNT = 1;
 
     /**
-     * @var string
+     * @var \SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface
      */
-    protected const STATIC_CONST_PREPOSITION = 'static';
+    protected PrefixedConstNameResolverInterface $prefixedConstNameResolver;
 
     /**
-     * @var string
+     * @param \SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface $prefixedConstNameResolver
      */
-    protected const PARENT_CONST_PREPOSITION = 'parent';
-
-    /**
-     * @var string
-     */
-    protected const PYZ_CONST_PREFIX = 'PYZ_';
-
-    /**
-     * @var array
-     */
-    protected const CONST_PREPOSITIONS = [
-        self::STATIC_CONST_PREPOSITION,
-        self::PARENT_CONST_PREPOSITION,
-    ];
-
-    /**
-     * @var \SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface
-     */
-    protected ClassConstantFinderInterface $classConstantFinder;
-
-    /**
-     * @var \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface
-     */
-    protected ClassLoaderInterface $classLoader;
-
-    /**
-     * @param \SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface $classConstantFinder
-     * @param \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface $classLoader
-     */
-    public function __construct(ClassConstantFinderInterface $classConstantFinder, ClassLoaderInterface $classLoader)
+    public function __construct(PrefixedConstNameResolverInterface $prefixedConstNameResolver)
     {
-        $this->classConstantFinder = $classConstantFinder;
-        $this->classLoader = $classLoader;
+        $this->prefixedConstNameResolver = $prefixedConstNameResolver;
     }
 
     /**
@@ -78,37 +47,14 @@ protected function createClassConstantExpression(
         string $className,
         string $constantName
     ): ClassConstFetch {
-        return (new BuilderFactory())->classConstFetch($className, $this->getClassConstantName($classInformationTransfer, $className, $constantName));
-    }
-
-    /**
-     * @param \SprykerSdk\Integrator\Transfer\ClassInformationTransfer $classInformationTransfer
-     * @param string $className
-     * @param string $constantName
-     *
-     * @return string
-     */
-    protected function getClassConstantName(ClassInformationTransfer $classInformationTransfer, string $className, string $constantName): string
-    {
-        $targetClassName = $className;
-
-        if (in_array($className, static::CONST_PREPOSITIONS, true)) {
-            $targetClassName = $classInformationTransfer->getClassName();
-
-            if ($targetClassName === null) {
-                return $constantName;
-            }
-        }
-
-        if (!$this->classLoader->classExist($targetClassName)) {
-            return $constantName;
-        }
-
-        $targetClass = $this->classLoader->loadClass($targetClassName);
-
-        $prefixedConstantName = static::PYZ_CONST_PREFIX . $constantName;
-
-        return $this->classConstantFinder->findConstantByName($targetClass, $prefixedConstantName) ? $prefixedConstantName : $constantName;
+        return (new BuilderFactory())->classConstFetch(
+            $className,
+            $this->prefixedConstNameResolver->resolveClassConstantName(
+                $classInformationTransfer,
+                $className,
+                $constantName,
+            ),
+        );
     }
 
     /**

diff --git a/src/Builder/Creator/MethodCreator.php b/src/Builder/Creator/MethodCreator.php
@@ -22,11 +22,10 @@
 use PhpParser\Node\Stmt\Return_;
 use PhpParser\NodeTraverser;
 use PhpParser\ParserFactory;
-use SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface;
 use SprykerSdk\Integrator\Builder\Exception\LiteralValueParsingException;
 use SprykerSdk\Integrator\Builder\Exception\NotFoundReturnExpressionException;
-use SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface;
 use SprykerSdk\Integrator\Builder\Finder\ClassNodeFinderInterface;
+use SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface;
 use SprykerSdk\Integrator\Builder\Visitor\AddMethodVisitor;
 use SprykerSdk\Integrator\Transfer\ClassInformationTransfer;
 
@@ -68,19 +67,17 @@ class MethodCreator extends AbstractMethodCreator implements MethodCreatorInterf
      * @param \SprykerSdk\Integrator\Builder\Creator\MethodDocBlockCreatorInterface $methodDocBlockCreator
      * @param \SprykerSdk\Integrator\Builder\Creator\MethodReturnTypeCreatorInterface $methodReturnTypeCreator
      * @param \PhpParser\ParserFactory $parserFactory
-     * @param \SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface $classConstantFinder
-     * @param \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface $classLoader
+     * @param \SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface $prefixedConstNameResolver
      */
     public function __construct(
         ClassNodeFinderInterface $classNodeFinder,
         MethodStatementsCreatorInterface $methodStatementsCreator,
         MethodDocBlockCreatorInterface $methodDocBlockCreator,
         MethodReturnTypeCreatorInterface $methodReturnTypeCreator,
         ParserFactory $parserFactory,
-        ClassConstantFinderInterface $classConstantFinder,
-        ClassLoaderInterface $classLoader
+        PrefixedConstNameResolverInterface $prefixedConstNameResolver
     ) {
-        parent::__construct($classConstantFinder, $classLoader);
+        parent::__construct($prefixedConstNameResolver);
 
         $this->classNodeFinder = $classNodeFinder;
         $this->methodStatementsCreator = $methodStatementsCreator;

diff --git a/src/Builder/Resolver/PrefixedConstNameResolver.php b/src/Builder/Resolver/PrefixedConstNameResolver.php
@@ -0,0 +1,77 @@
+<?php
+
+/**
+ * Copyright © 2016-present Spryker Systems GmbH. All rights reserved.
+ * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
+ */
+
+declare(strict_types=1);
+
+namespace SprykerSdk\Integrator\Builder\Resolver;
+
+use SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface;
+use SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface;
+use SprykerSdk\Integrator\Transfer\ClassInformationTransfer;
+
+class PrefixedConstNameResolver implements PrefixedConstNameResolverInterface
+{
+    /**
+     * @var array<string>
+     */
+    protected const CONST_PREPOSITIONS = ['static', 'self', 'parent'];
+
+    /**
+     * @var string
+     */
+    protected const PYZ_CONST_PREFIX = 'PYZ_';
+
+    /**
+     * @var \SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface
+     */
+    protected ClassConstantFinderInterface $classConstantFinder;
+
+    /**
+     * @var \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface
+     */
+    protected ClassLoaderInterface $classLoader;
+
+    /**
+     * @param \SprykerSdk\Integrator\Builder\Finder\ClassConstantFinderInterface $classConstantFinder
+     * @param \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface $classLoader
+     */
+    public function __construct(ClassConstantFinderInterface $classConstantFinder, ClassLoaderInterface $classLoader)
+    {
+        $this->classConstantFinder = $classConstantFinder;
+        $this->classLoader = $classLoader;
+    }
+
+    /**
+     * @param \SprykerSdk\Integrator\Transfer\ClassInformationTransfer $classInformationTransfer
+     * @param string $className
+     * @param string $constantName
+     *
+     * @return string
+     */
+    public function resolveClassConstantName(ClassInformationTransfer $classInformationTransfer, string $className, string $constantName): string
+    {
+        $targetClassName = $className;
+
+        if (in_array($className, static::CONST_PREPOSITIONS, true)) {
+            $targetClassName = $classInformationTransfer->getClassName();
+
+            if ($targetClassName === null) {
+                return $constantName;
+            }
+        }
+
+        if (!$this->classLoader->classExist($targetClassName)) {
+            return $constantName;
+        }
+
+        $targetClass = $this->classLoader->loadClass($targetClassName);
+
+        $prefixedConstantName = static::PYZ_CONST_PREFIX . $constantName;
+
+        return $this->classConstantFinder->findConstantByName($targetClass, $prefixedConstantName) ? $prefixedConstantName : $constantName;
+    }
+}
diff --git a/src/Builder/Resolver/PrefixedConstNameResolverInterface.php b/src/Builder/Resolver/PrefixedConstNameResolverInterface.php
@@ -0,0 +1,24 @@
+<?php
+
+/**
+ * Copyright © 2016-present Spryker Systems GmbH. All rights reserved.
+ * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file.
+ */
+
+declare(strict_types=1);
+
+namespace SprykerSdk\Integrator\Builder\Resolver;
+
+use SprykerSdk\Integrator\Transfer\ClassInformationTransfer;
+
+interface PrefixedConstNameResolverInterface
+{
+    /**
+     * @param \SprykerSdk\Integrator\Transfer\ClassInformationTransfer $classInformationTransfer
+     * @param string $className
+     * @param string $constantName
+     *
+     * @return string
+     */
+    public function resolveClassConstantName(ClassInformationTransfer $classInformationTransfer, string $className, string $constantName): string;
+}
diff --git a/src/IntegratorFactory.php b/src/IntegratorFactory.php
@@ -104,6 +104,8 @@
 use SprykerSdk\Integrator\Builder\Printer\ClassDiffPrinter;
 use SprykerSdk\Integrator\Builder\Printer\ClassDiffPrinterInterface;
 use SprykerSdk\Integrator\Builder\Printer\ClassPrinter;
+use SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolver;
+use SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface;
 use SprykerSdk\Integrator\Builder\Visitor\PluginPositionResolver\PluginPositionResolver;
 use SprykerSdk\Integrator\Builder\Visitor\PluginPositionResolver\PluginPositionResolverInterface;
 use SprykerSdk\Integrator\Communication\ReleaseApp\ModuleRatingFetcher;
@@ -620,6 +622,14 @@ public function createClassResolver(): ClassResolverInterface
         return new ClassResolver($this->createClassLoader(), $this->createClassGenerator());
     }
 
+    /**
+     * @return \SprykerSdk\Integrator\Builder\Resolver\PrefixedConstNameResolverInterface
+     */
+    protected function createPrefixedConstNameResolver(): PrefixedConstNameResolverInterface
+    {
+        return new PrefixedConstNameResolver($this->createClassConstantFinder(), $this->createClassLoader());
+    }
+
     /**
      * @return \SprykerSdk\Integrator\Builder\ClassLoader\ClassLoaderInterface
      */
@@ -696,8 +706,7 @@ public function createMethodCreator(): MethodCreatorInterface
             $this->createMethodDocBlockCreator(),
             $this->createMethodReturnTypeCreator(),
             $this->createParserFactory(),
-            $this->createClassConstantFinder(),
-            $this->createClassLoader(),
+            $this->createPrefixedConstNameResolver(),
         );
     }
 
@@ -723,8 +732,7 @@ public function createMethodReturnTypeCreator(): MethodReturnTypeCreatorInterfac
     public function createMethodStatementsCreator(): MethodStatementsCreatorInterface
     {
         return new MethodStatementsCreator(
-            $this->createClassConstantFinder(),
-            $this->createClassLoader(),
+            $this->createPrefixedConstNameResolver(),
         );
     }