Skip to content

Commit

Permalink
FRW-7460: Fixed multitype in AbstractValueExtractorStrategy, Updated CI
Browse files Browse the repository at this point in the history
  • Loading branch information
vol4onok committed Feb 27, 2024
1 parent b5d7bdf commit e0330b6
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/trigger-remote-pr-in-release-app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
TARGET_REPO: release-app
SOURCE_PACKAGE_NAME: 'spryker-sdk/integrator'
PR_LABELS: 'composer dependencies'
PR_ASSIGNEES: pavelmaksimov25,DmytroKlymanSpryker
PR_ASSIGNEES: vol4onok,asmarovydlo

on:
release:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/trigger-remote-pr-in-upgrader.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ env:
TARGET_REPO: upgrader
SOURCE_PACKAGE_NAME: 'spryker-sdk/integrator'
PR_LABELS: 'composer dependencies'
PR_ASSIGNEES: pavelmaksimov25,DmytroKlymanSpryker
PR_ASSIGNEES: vol4onok,asmarovydlo

on:
release:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -88,14 +88,14 @@ protected function createArrayStringFromResult(array $array): string

continue;
}
if (!$this->isConstant($key)) {
if (is_string($key) && !$this->isConstant($key)) {

Check warning on line 91 in src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php

View check run for this annotation

Codecov / codecov/patch

src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php#L91

Added line #L91 was not covered by tests
$key = sprintf('\'%s\'', $key);
}
if (!$this->isConstant($value)) {
if (is_string($key) && !$this->isConstant($value)) {

Check warning on line 94 in src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php

View check run for this annotation

Codecov / codecov/patch

src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php#L94

Added line #L94 was not covered by tests
$value = sprintf('\'%s\'', $value);
}

$result[] = sprintf('%s => %s', $key, $value);
$result[] = $key . ' => ' . $value;

Check warning on line 98 in src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php

View check run for this annotation

Codecov / codecov/patch

src/Builder/Extractor/ValueExtractor/AbstractValueExtractorStrategy.php#L98

Added line #L98 was not covered by tests
}

return sprintf('[%s]', implode(', ', $result));
Expand Down

0 comments on commit e0330b6

Please sign in to comment.