Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-2708: Add PYZ constant check #149

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

sergeyspryker
Copy link
Contributor

@sergeyspryker sergeyspryker changed the title SDK-2708 add PYZ check SDK-2708 add PYZ constant check Oct 18, 2023
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (2a9a840) 86.03% compared to head (035eff3) 86.15%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #149      +/-   ##
============================================
+ Coverage     86.03%   86.15%   +0.12%     
- Complexity     1659     1673      +14     
============================================
  Files           146      148       +2     
  Lines          4394     4432      +38     
============================================
+ Hits           3780     3818      +38     
  Misses          614      614              
Files Coverage Δ
...ssModifier/ClassConstant/ClassConstantModifier.php 83.33% <100.00%> (-4.17%) ⬇️
src/Builder/Creator/AbstractMethodCreator.php 100.00% <100.00%> (ø)
src/Builder/Creator/MethodCreator.php 96.55% <100.00%> (+0.08%) ⬆️
src/Builder/Finder/ClassConstantFinder.php 100.00% <100.00%> (ø)
src/Builder/Resolver/PrefixedConstNameResolver.php 100.00% <100.00%> (ø)
src/IntegratorFactory.php 96.07% <100.00%> (+0.06%) ⬆️
src/ManifestStrategy/GlossaryManifestStrategy.php 89.55% <100.00%> (ø)
src/Builder/Creator/MethodStatementsCreator.php 90.00% <76.92%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroKlymanSpryker DmytroKlymanSpryker changed the title SDK-2708 add PYZ constant check SDK-2708: Add PYZ constant check Oct 24, 2023
@DmytroKlymanSpryker DmytroKlymanSpryker merged commit 48f4eb9 into master Oct 24, 2023
9 checks passed
@DmytroKlymanSpryker DmytroKlymanSpryker deleted the bugfix/sdk-2708-add-pyz-check branch October 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants