[APPS-4380] Components upgrade #15
Conversation
Codecov Report
@@ Coverage Diff @@
## feature/apps-4380-add-default-endpoints #15 +/- ##
=============================================================================
- Coverage 100.00% 97.72% -2.28%
+ Complexity 308 305 -3
=============================================================================
Files 25 28 +3
Lines 758 744 -14
=============================================================================
- Hits 758 727 -31
- Misses 0 17 +17
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
I had to skip one of existing tests due to the fact part of functionality was disabled. |
bohdan-turchyk-spryker
changed the title
| @@ -25,9 +25,7 @@ public function cleanUnused(OpenApi $openApi): OpenApi | |||
|
|
|||
| $references = ReferenceFinder::findInArray($openApiAsArray); | |||
There was a problem hiding this comment.
Does anyone know why the OpenAPI schema is converted to JSON here as part of removing unused elements? There should definitely be a comment describing why that is necessary.
There was a problem hiding this comment.
I removed usage of this class but did not delete it for now - we may need to discuss this with Maksym when he's back from his vacation to understand if there is anything preventing us from deleting it.
| * @param string $pathName | ||
| * @param \cebe\openapi\spec\PathItem $sourcePathItem | ||
| * | ||
| * @return \cebe\openapi\spec\OpenApi | ||
| */ | ||
| protected function mergePath( | ||
| private function mergePath( |
There was a problem hiding this comment.
What was the reasoning for changing the visibility of this method?
There was a problem hiding this comment.
changed it back
| $openApi = $this->cleanUnusedParameters($openApi, $references); | ||
|
|
||
| return $this->cleanUnusedSchemas($openApi, $references); | ||
| return $this->cleanUnusedParameters($openApi, $references); |
There was a problem hiding this comment.
I don't remember seeing cleanup as part of the specification. What was the argument for implementing this, rather than treating unused parameters as a bug in the component sending the OpenAPI schema update?
There was a problem hiding this comment.
Removed usage
Update components merger class to allow adding components-only schemas to openapi files