Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BO-2260: Added IG for merchant portal forgot password functionality. #112

Open
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

sakharova-yuliia
Copy link
Contributor

@sakharova-yuliia sakharova-yuliia commented Jun 24, 2021

PR Description

Epic ticket: https://spryker.atlassian.net/browse/BO-294

Checklist

  • I agree with the Code Contribution License Agreement in CONTRIBUTING.md

Copy link
Contributor

@asmarovydlo asmarovydlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes for marketplace-merchant-portal-core-feature-integration.md that previously was part of the PR disappeared, you can find them by clicking on any comment added to the file. (e.g. https://github.com/spryker/spryker-docs/pull/112/files/6690187e68912a5a5ae0d25f2c7c8f601d03bb0b#diff-72315b4688facf268d0d1c50127d0dd2d326509668972065606383235cfec84c)

Please get them back

Comment on lines 20 to 22
| Spryker Core | {{page.version}} | [Spryker Core feature integration](https://documentation.spryker.com/docs/spryker-core-feature-integration) |
| CMS | {{page.version}} | [Spryker CMS feature integration](https://documentation.spryker.com/docs/cms)
| Marketplace Merchant Portal Core | {{page.version}} | [Marketplace Merchant Portal Core](/docs/marketplace/dev/feature-integration-guides/{{ page.version }}/merchant-portal-core-feature-integration.html)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add correct doc names and links

Comment on lines 58 to 64
2. Add the following csv file:

Import CMS blocks:

```bash
console data:import:cms-block
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is missing here

Comment on lines 98 to 101
Make sure that the following data has been added to the database:

* `spy_cms_block`
* `spy_cms_block_store`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not clear. I assume the database tables should be updated?

@@ -250,6 +250,8 @@ Set up the following behaviors.
| MerchantUserUserRoleFilterPlugin | Filters `ROLE_BACK_OFFICE_USER` to prevent a merchant user from logging into the Back Office. | | Spryker\Zed\MerchantUser\Communication\Plugin\SecurityGui |
| ProductViewerForOfferCreationAclInstallerPlugin | Provides `ProductViewerForOfferCreation` roles with rules and groups to create on installation. | | Spryker\Zed\AclMerchantPortal\Communication\Plugin\MerchantUser |
| AclGroupMerchantUserLoginRestrictionPlugin | Checks if the merchant user login is restricted. | | Spryker\Zed\AclMerchantPortal\Communication\Plugin\SecurityMerchantPortalGui |
| MailMerchantUserPasswordResetRequestStrategyPlugin | Checks if strategy is applicable for a password reset request. Returns true if merchant user exists, false otherwise. | | Spryker\Zed\MerchantUserPasswordResetMail\Communication\Plugin\UserPasswordReset |
| MerchantUserPasswordResetMailTypePlugin | Builds the mail of merchant password restore type. | | Spryker\Zed\MerchantUserPasswordResetMail\Communication\Plugin\Mail |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it create an email?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It creates a transfer that is further used to create email. Rephrased a bit.

@@ -0,0 +1,103 @@
---
title: Marketplace Merchant Portal Core feature + CMS integration
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Move the doc to incudes
  2. Update the name
  3. Update the filename

…al-forgot-password' into featuer/bo-2260-ig-merchant-portal-forgot-password

# Conflicts:
#	_includes/pbc/all/install-features/202410.0/marketplace/install-merchant-portal-core-cms-feature.md
#	_includes/pbc/all/install-features/202410.0/marketplace/install-the-marketplace-merchant-portal-core-feature.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants