-
Notifications
You must be signed in to change notification settings - Fork 98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update best-practices-for-effective-testing.md with clean facade #3027
Open
gerner-spryker
wants to merge
6
commits into
master
Choose a base branch
from
feature/ae-174/master-clean-facade
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerner-spryker
added
TW review needed
PR needs Technical writer's review
small changes
PR contains small changes, like typo fixes
labels
Jan 21, 2025
demkos
previously approved these changes
Jan 21, 2025
PhilinTv
reviewed
Jan 21, 2025
...guidelines/testing-guidelines/testing-best-practices/best-practices-for-effective-testing.md
Outdated
Show resolved
Hide resolved
PhilinTv
reviewed
Jan 21, 2025
...guidelines/testing-guidelines/testing-best-practices/best-practices-for-effective-testing.md
Outdated
Show resolved
Hide resolved
PhilinTv
reviewed
Jan 21, 2025
...guidelines/testing-guidelines/testing-best-practices/best-practices-for-effective-testing.md
Outdated
Show resolved
Hide resolved
andriitserkovnyi
added
in tech review
PR is in review by a developer
and removed
TW review needed
PR needs Technical writer's review
labels
Jan 22, 2025
…es/best-practices-for-effective-testing.md Co-authored-by: Denis Turkov <denis.turkov@spryker.com>
…es/best-practices-for-effective-testing.md Co-authored-by: Denis Turkov <denis.turkov@spryker.com>
…es/best-practices-for-effective-testing.md Co-authored-by: Denis Turkov <denis.turkov@spryker.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
in tech review
PR is in review by a developer
small changes
PR contains small changes, like typo fixes
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Plugins are allowed to bypass Facade, thus the testing directives over the API, have to be adjusted. Previously all test have happened through Facade, now it is divided to Facade + Plugins.
Tickets
https://spryker.atlassian.net/browse/AE-174
Checklist