Improved Handling for Problems in Closed/Deleted Files #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR. This will be released in v3.1.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, if
lintEntireProjectis turned on, theonDidCloseTextDocumentlogic will not delete any diagnostics from the Problems tab. This is desirable in most cases, however if I close a file that's not in the workspace (i.e. unnamed SQLQuery_1) or ifonDidCloseTextDocumentgets called by the editor for a file that got closed because it was deleted, the diagnostics for the file should be removed in those cases.The screenshot below shows an example where SQLQuery_2 and SQLQuery_3 were closed without being saved but still show in the Problems tab even though they are not files in the active workspace/project directory. This is undesirable because it results in the Problems tab showing linting errors for files that don't exist anymore.