Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v3.49.0 #99

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Release v3.49.0 #99

wants to merge 1 commit into from

Conversation

tomayac
Copy link
Collaborator

@tomayac tomayac commented Feb 7, 2025

I'm trying to release v3.49.0, but it fails:

sqlite3-worker1-bundler-friendly.mjs:44 Uncaught TypeError: Failed to execute 'importScripts' on 'WorkerGlobalScope': Module scripts don't support importScripts().

This diff is the problem, @sgbeal.

@sgbeal
Copy link
Collaborator

sgbeal commented Feb 7, 2025

i don't fully understand this one: one of our test scripts recently stopped working with the same error and i disabled it because that test had always worked in the past and i assumed that the browsers had simply decided that it no longer works that way. i will look into this ASAP and hope to have a resolution for you today.

@tomayac
Copy link
Collaborator Author

tomayac commented Feb 7, 2025

@sgbeal
Copy link
Collaborator

sgbeal commented Feb 7, 2025

This turns out to be a build problem - accessing makefile vars before an imported file sets them. i'll have a fix to you shortly.

@sgbeal
Copy link
Collaborator

sgbeal commented Feb 7, 2025

My sincere apologies for this hiccup. The current tip of the 3.49 branch has the fix for this (bug introduced via build refactoring): https://sqlite.org/src/timeline?r=branch-3.49

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants