Update button.handlebars adding after-icon #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explanation
{{#if after_icon}}: This new block checks if the after_icon parameter is provided. If it is, it renders the icon after the text.
In this way, the template will support both an icon before and after the text, depending on which parameters (icon or after_icon) are provided.
|
Great, thanks for the pr ! Can you also, in the same pull request, add the new item to the documentation: https://github.com/lovasoa/SQLpage/blob/main/examples/official-site/sqlpage/migrations/18_button.sql ? Don't close this PR, just amend it. |
lovasoa
added a commit
that referenced
this pull request
May 29, 2024
|
@amrutadotorg : don't worry, I did it myself in e5a9649 . Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
{{#if after_icon}}: This new block checks if the after_icon parameter is provided. If it is, it renders the icon after the text. In this way, the template will support both an icon before and after the text, depending on which parameters (icon or after_icon) are provided.