Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: open a new tab when clicking on the menu and submenu. #632

Merged
merged 3 commits into from
Oct 1, 2024

Conversation

sijucj
Copy link

@sijucj sijucj commented Oct 1, 2024

sample follows

select 
    'shell'                     as component,
    'SQLPage: SQL to web pages' as title,
    'database'                  as icon,
    '/'                         as link,  
    JSON('{"title":"Community","submenu":[{"link":"//github.com/lovasoa/sqlpage/issues","title":"Report a bug","icon":"bug","target":"__blank"}]}') as menu_item,
    JSON('{"title":"Report a bug","link":"//github.com/lovasoa/sqlpage/issues","target":"__blank"}') as menu_item,
    'boxed'                     as layout,
    'en-US'                     as language,
    'Go from SQL queries to web applications in an instant.' as description,
    'https://sql.datapage.app/sqlpage_social_preview.webp' as preview_image,
    'Poppins'                   as font,
    'https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11/build/highlight.min.js' as javascript,
    'https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11/build/languages/sql.min.js' as javascript,
    'https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11/build/languages/handlebars.min.js' as javascript,
    'https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11/build/languages/json.min.js' as javascript,
    '/highlightjs-launch.js'    as javascript,
    '/highlightjs-tabler-theme.css' as css,
    'Official [SQLPage](https://sql.datapage.app) documentation' as footer;

@lovasoa
Copy link
Collaborator

lovasoa commented Oct 1, 2024

Great! We also need to document this new option

- "_blank" to open the link in a new tab
- "_self" to open it in the same tab
- "_parent" to open it in the parent frame
- "_top" to open it in the full body of the window
@sijucj
Copy link
Author

sijucj commented Oct 1, 2024

https://github.com/lovasoa/SQLpage/blob/9fd29619fc643934beb28f946cdd745402a9200c/examples/official-site/sqlpage/migrations/01_documentation.sql#L948

I have updated the file and pushed it

@lovasoa lovasoa merged commit 86b273b into sqlpage:main Oct 1, 2024
10 checks passed
@lovasoa
Copy link
Collaborator

lovasoa commented Oct 1, 2024

Thank you !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants