Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Gradle task to check if dependencies are sorted cacheable #115

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Make Gradle task to check if dependencies are sorted cacheable #115

wants to merge 2 commits into from

Conversation

nebulon42
Copy link

@nebulon42 nebulon42 commented Sep 25, 2024 •
edited
Loading

This disentangles sort and check tasks to make the check task cacheable as it does not modify the build script.
Relates to #108.

@nebulon42 nebulon42 marked this pull request as ready for review September 25, 2024 14:50
autonomousapps
autonomousapps reviewed Oct 10, 2024
View reviewed changes
Copy link
Collaborator

@autonomousapps autonomousapps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Left one question.

sort-dependencies-gradle-plugin/src/main/kotlin/com/squareup/sort/BaseSortDependenciesTask.kt Outdated Show resolved Hide resolved
@nebulon42 nebulon42 force-pushed the check-cacheable branch 3 times, most recently from 0c869f5 to c13900d Compare October 14, 2024 11:23
@nebulon42
Copy link
Author

I took the opportunity to add another commit which emits a VerificationException when unsorted. For Gradle on the command line this improves the error message. If Develocity is used this avoids a "non-verification failure" classification which would be used for e.g. infrastructure problems (more on the topic).

@CLAassistant
Copy link

CLAassistant commented Jan 9, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@nebulon42
Copy link
Author

Rebased this.

@nebulon42
Copy link
Author

Fixed problems introduced by rebase.

@nebulon42
Copy link
Author

CI failure does not seem to be related to my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@autonomousapps autonomousapps autonomousapps left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nebulon42 @CLAassistant @autonomousapps