Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the gradle.properties VERSION to jar artifacts #92

Closed
wants to merge 3 commits into from
Closed

Adds the gradle.properties VERSION to jar artifacts #92

wants to merge 3 commits into from

Conversation

ivanalvarado
Copy link
Contributor

@ivanalvarado ivanalvarado commented Feb 14, 2024 •
edited
Loading

Description

  • I noticed running the version command -V for the jar always returns the hardcoded 0.1
  • This PR adds support for expanding the VERSION property into a resource file that gets distributed with the jar, and provides the version to the SortCommand at runtime.
  • PicoCLI Version Provider Documentation

@ZacSweers
Copy link
Collaborator

We're going to move away from PicoCLI in #91, so this isn't needed anymore. Thanks though!

@ZacSweers ZacSweers closed this Feb 14, 2024
@ivanalvarado ivanalvarado mentioned this pull request Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivanalvarado @ZacSweers