Merged
Conversation
| val processingMode = convertToProcessingMode(getIntOrNull("processingMode")) | ||
| requireNotNull(amountMoney) { "Amount money is required" } | ||
| requireNotNull(processingMode) { "processingMode is required" } | ||
| val allowCardSurcharge = getBooleanOrNull("allowCardSurcharge") ?: false |
There was a problem hiding this comment.
We should be making this a required field. I know iOS has a default, but I believe the idea was to make it required. @shauna-kimura thoughts?
| // Required | ||
| amountMoney: Money; | ||
| processingMode: Number; | ||
| allowCardSurcharge?: Boolean; //required for Android |
There was a problem hiding this comment.
ohh does this make it required only for android?
brandonjenniges
approved these changes
Nov 18, 2025
matheuskiser
approved these changes
Nov 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR upgrades native Android and iOS SDKs
Android: 2.3.4
iOS: 2.3.1