Closed
Conversation
oldergod
approved these changes
Apr 15, 2024
Comment on lines
+75
to
+78
| // If this file system is already an extension wrapper, replace it rather than wrapping again. | ||
| // Note that this optimization doesn't apply to ForwardingFileSystem subclasses, only to the | ||
| // ForwardingFileSystem base class. | ||
| if (this::class === ForwardingFileSystem::class) { |
Member
There was a problem hiding this comment.
I don't understand why we don't want to, or cannot support subclasses with this is ForwardingFileSystem ?
Collaborator
Author
There was a problem hiding this comment.
This coalesces two ForwardingFileSystem wrappers into one. But it only works if there’s no other methods overridden in the ForwardingFileSystem. If there are, then we shouldn’t replace the users’ subtype with the base type.
oldergod
approved these changes
Apr 16, 2024
Comment on lines
+385
to
+386
| * When [extensionType] is requested on the returned file system, it will return [extension], | ||
| * regardless of what is returned by this file system. |
Member
There was a problem hiding this comment.
So you can shadow extensions ?
Member
There was a problem hiding this comment.
yes, I sas the overrideExtension test
yschimke
reviewed
May 24, 2024
Contributor
|
@swankjesse why is this closed? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1466