Allow groups_exempted, groups_enforced versions of their gids_ counterparts
#47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klieth
reviewed
Jan 14, 2019
sudo_pair/src/lib.rs
Outdated
| fn groupname_to_gid(groupname: &str) -> Option<gid_t> { | ||
| unsafe { | ||
| let groupname_c = CString::new(groupname).ok()?; | ||
| let group = libc::getgrnam(groupname_c.as_ptr()); |
There was a problem hiding this comment.
You should only need to put the unsafe around the libc::getgrnam I believe--I think it's the only unsafe thing in this function.
There was a problem hiding this comment.
getgrnam returns a struct group * (a pointer!) which we dereference with the unsafe method as_ref. But the CString part is safe, so we can pull it out.
stouset
force-pushed
the
groupnames
branch
4 times, most recently
from
104ba40 to
f43e566
Compare
klieth
previously approved these changes
Jan 15, 2019
|
Closing this due to lack of interest from the requesting party. I'm open to updating this and merging if someone else believes it would be useful. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #46.
Pushing the work so far, but I'll add tests when I have a moment.