-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Describe surprising side effects of auth_param basic #1612
Docs: Describe surprising side effects of auth_param basic #1612
Conversation
acl badGuys proxy_auth Bob http_access deny badGuys Admins may be surprised that their proxy_auth ACLs do not match users with logins identical to those listed as proxy_auth ACL values. For example, a user logged in as "Bob" will no match the above ACL if Basic authentication is used without an explicit "casesensitive on" setting. In fact, the above ACL cannot match any user in that environment!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR was triggered by surprising test results obtained while working on #1611: I was not expecting a case sensitivity setting, especially the default one, to result in altered usernames.
FWIW, I tried to verify statements in the updated text, but authentication caveats is not my expertise area, and I could have missed something important. I would prefer not to merge this PR without @yadij blessing (at least).
We should either document or remove this caveat, but I do not insist on any specific documentation text. If you can think of a better wording, please edit the proposed text or post specific replacement suggestions.
FYI, there is likely a bug involved here. When Squid sends
The absence of So, to fix this properly we need to:
[^1] by "always" I do mean everywhere. The |
I agree that the current behavior can be considered a bug (or a combination of bugs). We probably disagree on the specifics of that bug. I recommend merging this documentation (if we agree that it represents the current behavior that is unlikely to change in a few days) and then wait for improvements and fixes. When those improvements/fixes come, they will be reflected in the already merged documentation, assisting us with their impact comprehension. Regardless of whether these documentation improvements are merged, I recommend discussing any authentication configuration/implementation changes elsewhere. I see several significant red flags in the proposed changes, but it feels wrong to start reviewing that proposal here, especially if we agree that those changes are not going to be trivial and should be done in dedicated PR(s). If you are going to work on improving authentication along the lines of that proposal, please make an RFC on squid-dev, open a Draft PR (without any code changes at first), or something like that. |
@yadij any comments? I'll clear for merge on Dec 17th unless you have any, and then we can add looking into the bug to our backlog |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
acl badGuys proxy_auth Bob http_access deny badGuys Admins may be surprised that their proxy_auth ACLs do not match users with logins identical to those listed as proxy_auth ACL values. For example, a user logged in as "Bob" will no match the above ACL if Basic authentication is used without an explicit "casesensitive on" setting. In fact, the above ACL cannot match any user in that environment!
Admins may be surprised that their proxy_auth ACLs do not match users
with logins identical to those listed as proxy_auth ACL values. For
example, a user logged in as "Bob" will no match the above ACL if Basic
authentication is used without an explicit "casesensitive on" setting.
In fact, the above ACL cannot match any user in that environment!