-
Notifications
You must be signed in to change notification settings - Fork 538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V6 backports #1986
V6 backports #1986
Conversation
OpenBSD does not have libdl, as it has dlopen() in libc. It is not really needed, and force-requiring the presence of libdl causes ./configure to fail on openbsd: checking for dlopen in -ldl... no configure: error: Required library 'dl' not found
@kinkie, this being a backport of multiple changes it is destined for a rebase-merge instead of a squash-merge. That means edits like these review changes and build fixes need to be manually combined in the PR branch. if you were not aware how to do that:
N.B. Ideally manual backports are separate PRs to avoid this type of tricks. |
…1950) Creating a raw pointer with 1 as an address/value raised red flags, and it was difficult to interpret tricky peerRefreshDNS() logic correctly.
…id-cache#1931) ACLExtUser-based ACLs (i.e. ext_user and ext_user_regex) dereferenced a nil request pointer when they were used in a context without a request (e.g., when honoring on_unsupported_protocol). SourceDomainCheck-based ACLs (i.e. srcdomain and srcdom_regex) have a similar bug, although we do not know whether broken slow ACL code is reachable without a request (e.g., on_unsupported_protocol tests cannot reach that code until that directive starts supporting slow ACLs). This change does not start to require request presence for these two ACLs to avoid breaking any existing configurations that "work" without one.
18e911d
to
e5655ea
Compare
Thanks for the advice, and yes I'll do individual backports next time |
Backporting commits:
ACLExtUser and SourceDomainCheck ACLs