Merged
Conversation
…rets, Use of HTTP without TLS, Use of weak crypto algorithm, Integrity Policy, SSL/TLS/mTLS Policy.
…e to SSL/TLS/mTLS Policy code smell
…Encryption code smell
…Misconfiguration code smell; and minor fixes
… Insecure Access Control code smell
…me existing rules
Nfsaavedra
requested changes
Jan 1, 2024
Member
Nfsaavedra
left a comment
There was a problem hiding this comment.
Thanks for the PR! Also sorry for taking so long to review it. First, there are some merge conflicts that should be fixed. I also left some comments for improvements in the code. If you don't have the time to apply them, you can tell me and I'll do it. If you only want to apply them partially, you can also tell me what are the ones you will handle and I'll handle the remaining comments. Congrats again in your great work 🎉
Member
|
Merging! Thank you @joaotgoncalves! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Smells
Refactored smells:
Implemented security code smells defined for Terraform scripts:
A new Config file was created to be used for analyse Terraform files.
Each code smell was implemented using smell checkers to facilitate the interpretation and organization of the code.