Don't panic when scanning map interface types

Signed-off-by: JoramWilander <jwawilander@gmail.com>
src-d · Jul 24, 2018 · 9175115 · 9175115
1 parent 5fd124f
commit 9175115
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/scanner/scanner.go b/scanner/scanner.go
@@ -243,6 +243,10 @@ func scanType(typ types.Type) (t Type) {
 	case *types.Map:
 		key := scanType(u.Key())
 		val := scanType(u.Elem())
+		if val == nil {
+			report.Warn("ignoring map with value type %s", typ.String())
+			return nil
+		}
 		t = NewMap(key, val)
 	default:
 		report.Warn("ignoring type %s", typ.String())

diff --git a/scanner/scanner_test.go b/scanner/scanner_test.go
@@ -93,6 +93,11 @@ func TestScanType(t *testing.T) {
 			types.NewInterface(nil, nil),
 			nil,
 		},
+		{
+			"map interface",
+			types.NewMap(types.Typ[types.String], &types.Interface{}),
+			nil,
+		},
 	}
 
 	for _, c := range cases {