refacotr: re-fix the print column for topologyReady

apis/v1alpha1/topology.go

@@ -93,6 +93,9 @@ type TopologyStatus struct {
 	// by the k8s startup/readiness probe (which is in turn managed by the status probe
 	// configuration of the topology). The possible values are "notready" and "ready", "unknown".
 	NodeReadiness map[string]string `json:"nodeReadiness"`
+	// TopologyReady indicates if all nodes in the topology have reported ready. This is duplicated
+	// from the conditions so we can easily snag it for print columns!
+	TopologyReady bool `json:"topologyReady"`
 	// Conditions is a list of conditions for the topology custom resource.
 	Conditions []metav1.Condition `json:"conditions"`
 }

assets/crd/clabernetes.containerlab.dev_topologies.yaml

@@ -773,6 +773,11 @@ spec:
                   if it is unset (nil) when a Topology is created, the controller will use the default global
                   config value (false); if the field is non-nil, this status field will hold the non-nil value.
                 type: boolean
+              topologyReady:
+                description: |-
+                  TopologyReady indicates if all nodes in the topology have reported ready. This is duplicated
+                  from the conditions so we can easily snag it for print columns!
+                type: boolean
             required:
             - conditions
             - configs
@@ -781,6 +786,7 @@ spec:
             - nodeReadiness
             - reconcileHashes
             - removeTopologyPrefix
+            - topologyReady
             type: object
         type: object
     served: true

charts/clabernetes/crds/clabernetes.containerlab.dev_topologies.yaml

@@ -773,6 +773,11 @@ spec:
                   if it is unset (nil) when a Topology is created, the controller will use the default global
                   config value (false); if the field is non-nil, this status field will hold the non-nil value.
                 type: boolean
+              topologyReady:
+                description: |-
+                  TopologyReady indicates if all nodes in the topology have reported ready. This is duplicated
+                  from the conditions so we can easily snag it for print columns!
+                type: boolean
             required:
             - conditions
             - configs
@@ -781,6 +786,7 @@ spec:
             - nodeReadiness
             - reconcileHashes
             - removeTopologyPrefix
+            - topologyReady
             type: object
         type: object
     served: true

controllers/topology/reconciledata.go

@@ -91,6 +91,7 @@ func (r *ReconcileData) SetStatus(
 	}
 
 	owningTopologyStatus.NodeReadiness = r.NodeStatuses
+	owningTopologyStatus.TopologyReady = r.TopologyReady
 
 	return nil
 }

controllers/topology/reconciler.go

@@ -887,6 +887,8 @@ func (r *Reconciler) ReconcileDeployments( //nolint: gocyclo
 	}
 
 	if topologyReady {
+		reconcileData.TopologyReady = true
+
 		apimachinerymeta.SetStatusCondition(&owningTopology.Status.Conditions, metav1.Condition{
 			Type:    "TopologyReady",
 			Status:  "True",

testhelper/kubernetes.go

@@ -98,6 +98,11 @@ func NormalizeTopology(t *testing.T, objectData []byte) []byte {
 		objectData,
 		"del(.status.nodeReadiness)",
 	)
+	objectData = YQCommand(
+		t,
+		objectData,
+		"del(.status.topologyReady)",
+	)
 
 	return objectData
 }