Skip to content

Support for SSH Public Key Provisioning for vr-sros #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 6 commits into from

Conversation

mabra94
Copy link
Contributor

@mabra94 mabra94 commented Oct 30, 2023

Added support to automatically provision SSH public keys into vr-sros nodes.
Used the embed function to store my config command template in a dedicated external file. I liked this approach better than to specify the commands directly in the vr-sros.go file.

I created a dedicated function for the health check/readiness probe.

I would like to improve sessions handling a bit though. I would prefer to re-use the same session for the readiness probe, the applyPartialConfig and the applyDefaultConfig functions. Although it works as is, I would be also happy about a pointer on how to improve this.

@hellt
Copy link
Member

hellt commented Oct 30, 2023

Hi @mabra94
thanks a lot for your contribution! I am currently on a business trip, so the review will be delayed a bit, but from what I see in the pipeline regarding the failed tests is that the CI (and local dev) is set to use Go 1.20, where slices package hasn't been promoted to stdlib just yet.
You can swap it to "golang.org/x/exp/slices" to make it work

@mabra94
Copy link
Contributor Author

mabra94 commented Oct 30, 2023

Thanks for the pointer. Did that

@hellt hellt requested review from steiler and removed request for steiler November 6, 2023 22:03
@hellt
Copy link
Member

hellt commented Nov 8, 2023

superseded by #1706

@hellt hellt closed this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants