Skip to content

Export ssh public keys under ssh-pub-keys in topo json #2387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 11, 2025

move ssh pub keys out of clab config tree

02bf3cc
Select commit
Loading
Failed to load commit list.
Merged

Export ssh public keys under ssh-pub-keys in topo json #2387

move ssh pub keys out of clab config tree
02bf3cc
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 11, 2025 in 0s

51.88% (-0.03%) compared to dd321ab

View this Pull Request on Codecov

51.88% (-0.03%) compared to dd321ab

Details

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.88%. Comparing base (dd321ab) to head (02bf3cc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2387      +/-   ##
==========================================
- Coverage   51.91%   51.88%   -0.03%     
==========================================
  Files         173      172       -1     
  Lines       17299    17302       +3     
==========================================
- Hits         8980     8978       -2     
- Misses       7378     7381       +3     
- Partials      941      943       +2     
Files with missing lines Coverage Δ
clab/export.go 75.32% <100.00%> (+5.58%) ⬆️
nodes/srl/version.go 75.43% <100.00%> (ø)
utils/ssh.go 91.66% <100.00%> (+8.33%) ⬆️

... and 2 files with indirect coverage changes