Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove gomplate #2426

Merged
merged 2 commits into from
Jan 30, 2025
Merged

Remove gomplate #2426

merged 2 commits into from
Jan 30, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Jan 29, 2025

fix #2414

let's see if anyone used it

@hellt
Copy link
Member Author

hellt commented Jan 29, 2025

@kaelemc can you give this PR a try with iol? I think the failures are caused by the flakiness in gh actions, because I don't think you used any gomplate templates in the iol template, at lest they don't jump out at me

@kaelemc
Copy link
Contributor

kaelemc commented Jan 29, 2025

@hellt I took a look, and both IOL + XRd are generating templates correctly. I do however get this error (both on IOL and XRd)

image

@kaelemc
Copy link
Contributor

kaelemc commented Jan 29, 2025

Adding one more thing. The XRd configuration template is broken (n.GenerateConfig(nodeCfg.ResStartupConfig, cfgTemplate)), Looks like the mgmt interface addressing is not being populated.

The template for the script which 'fixes' the management IPv6 addr (to prevent multiple IPv6 addresses on the management interface after redeployments) is working fine.

@axxyhtrx
Copy link
Contributor

axxyhtrx commented Jan 30, 2025

Wow....
Just look to the size of binaries.

70M before and 36M after removing gomplate.

With gomplate:
Screenshot 2025-01-30 at 11 56 59

Without gomplate:
Screenshot 2025-01-30 at 11 56 00

@hellt
Copy link
Member Author

hellt commented Jan 30, 2025

@kaelemc looks like iol tests are back, and I haven't changed much...

Regarding the xrd I don't think this PR caused any trouble, since the xrd template did not use any of the gomplate functions...

@hellt hellt merged commit d922b88 into main Jan 30, 2025
64 of 65 checks passed
@hellt hellt deleted the remove-gomplate branch January 30, 2025 08:42
@kaelemc
Copy link
Contributor

kaelemc commented Jan 30, 2025

@hellt Don't mind me, I was just hallucinating 😆. XRd isn't even supposed to populating mgmt ip in the template config anyways. Looks like all is working well and good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove gomplate
3 participants