Implemented a new snow interception module and fixed segfault issue when running crhm-cli#462
Closed
acebulsk wants to merge 16 commits intosrlabUsask:masterfrom
Closed
Implemented a new snow interception module and fixed segfault issue when running crhm-cli#462acebulsk wants to merge 16 commits intosrlabUsask:masterfrom
acebulsk wants to merge 16 commits intosrlabUsask:masterfrom
Conversation
…pears to work using new files w old algorithm now to modify.
…x canopy snow load for sublimation to constant
…ltwater unloading switch
…ding switch. now we are getting exactly the same as before adding the switches
…n startdate equaled the first obs date
Collaborator
Author
|
Closing after more recent PR #471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new snow interception module
CanopyVectorBasedhas been added which is described in detail in the manuscript which has been submitted to the Hydrological Processes journal (Cebulski & Pomeroy) available here.General Description of
CanopyVectorBasedA
switchparameter set in the prj file controls the ablation parameterization used in theCanopyVectorBasedmodule:SublimationSwitch== 1 turns on canopy snow sublimation using Pomeroy et al., (1998)SublimationSwitch== 0 turns off sublimation of canopy snow for testingMassUnloadingSwitch== 0 is the mass unloading portion of the latest iteration of the Hedstrom & Pomeroy 1998 unloading with modifications by Ellis et al. (2010) and Floyd (2012)MassUnloadingSwitch== 1 are the new ablation parameterisations developed at fortress mountain based on wind speed, duration, and air temperature.TODO
CLASSor the existing CRHM modulePSPnewwhich currently does not workOther Important Changes
#460 appears to be resolved for now.