Cbal v1 - new canopy snow routine#469
Closed
acebulsk wants to merge 120 commits intosrlabUsask:masterfrom
Closed
Conversation
…pears to work using new files w old algorithm now to modify.
…x canopy snow load for sublimation to constant
…ltwater unloading switch
…ding switch. now we are getting exactly the same as before adding the switches
…. Originally was immediately segfaulting due to some coding bugs.
…n startdate equaled the first obs date
…realistic canopy and ice sphere temps but still need to validate and plot the temps and energy terms
…d from canopy module. also fixed infinite loop error.
… is different in PSPnew. changed wind reference height to work with fortress instruments where wind is at mid canopy
…ome variables to global, and some internal params to global
added Switch to change between cionco or log wind profiles changed Sicart 2006 cloudy longwave to use last computed value when QdflatE == 0 Adjusted energy bal check
… profile currently only used for trajectory calculation, should also use this for unloading
also changed to pull ground temperature form Canopy module
…e origin to with intercept models
…snow was added to the snowpack
…le to use cionco wind profile for IP and ablation
…is still entered if no snow but still liquid
…r non canopy hrus. also casted switches to ints to avoid issues with parameter values which are longs when compared against the specified integer values
Collaborator
Author
|
Closing after more recent PR #471 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First go at implementing new canopy snow energy and mass budgets as new CRHM module. Caught some bugs in other modules / files along the way which should be assessed. The main changes are the addition of two new modules to represent the initial loading of snow in the canopy:
CanopyVectorBasedwhich follows developments from Cebulski & Pomeroy (2025b)the second module is:
CanSnobalwhich follows developments from Cebulski & Pomeroy (in prep.)together these new modules replace the canopy snow routines previously incorporated in
CanopyClearingGap. The original radiation routines inCanopyClearingGapwere copied over to theCanopyVectorBasedmodule which feeds into the surface snowpack routines soCanopyClearingGapis no longer needed.Note: there are several commits that are non-relevant as initial attempts to this were to revive the PSP module from Parv et al., (2000) however I could not get this working so ended up creating something new.