Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix where some tei:ref elements added outside of their tei:bibl #1937

Open
wlpotter opened this issue Oct 4, 2024 · 0 comments
Open

Fix where some tei:ref elements added outside of their tei:bibl #1937

wlpotter opened this issue Oct 4, 2024 · 0 comments
Assignees
Labels
data-normalization For use by General Editors only student For use by General Editors only

Comments

@wlpotter
Copy link
Contributor

wlpotter commented Oct 4, 2024

Some of the ref elements used to point to bibliographic records got added outside of the tei:bibl element. These need to be found and moved back into the bibl element so they properly nest.

Please use the fa24-student-edits branch. Please also note the following since several students will be working on this branch at once:

  • Please make sure to regularly "Fetch origin" and "pull changes" when beginning a work session
  • Please make commits on a per file basis, i.e. try to avoid having changes across multiple files in a single commit
  • Don't forget to push the commits up to the remote server
  • If you get any errors related to merge conflicts when pushing changes, let Will know

Workflow:

To find these instances, use the following find-in-files query (ctrl/cmd+shift+h)
Find-in-files:

  • Text to find: zotero (then re-search on smblBibl
  • Restrict to Xpath: ref[not(parent::bibl)]/@target

For each instance, move the full tei:ref element into the corresponding tei:bibl element

  • triple-clicking on the element name "ref" should select the entire element
  • cut (cmd/ctrl+x) and past (cmd/ctrl+v) the element at the end of the tei:bibl element it should be contained within

In most cases, it should be clear which bibl element it belongs to, but if not you may need to open the link in the @target attribute and verify which bibl entry it refers to.

For checking the ones that have "smbBibl" instead of a Zotero link, use the following google sheet: New Syriaca Bibliography Records. Find the ID in the "localId" column and then check the citation in the "Citation in Wright" column

Once all of the changes have been made and committed for all of the files, i.e. when searching in all files for "zotero" and "smblBibl" returns 0 results when you restrict by the above Xpath, please make a comment on this issue and tag Will with @wlpotter

@wlpotter wlpotter added data-normalization For use by General Editors only student For use by General Editors only labels Oct 4, 2024
@wlpotter wlpotter added this to the Version 1.0 Release milestone Oct 4, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
haeleekim added a commit that referenced this issue Oct 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-normalization For use by General Editors only student For use by General Editors only
Projects
Development

No branches or pull requests

2 participants