asn1: fix for byte buffer to uint64_t helper #1008
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Huff <alexandrehuff@utfpr.edu.br>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This is a proposal of a fix in the function that converts a byte_buffer to a uint64_t value.
Currently, when the size of a byte_buffer is greater than 1, the code mistakenly converts the bytes into an incorrect uint64_t value.
The
static_cast<uint64_t>((nbytes - 1 - i) * 8U)erroneously inverts the order of the bits in the resulting value, so that functionsvoid octet_string_helper::to_octet_string(srsran::byte_buffer& buf, uint64_t number)anduint64_t octet_string_helper::to_uint(const byte_buffer& buf)are not equivalent.