Refactor engine and metrics code for clarity and performance#9
Merged
Refactor engine and metrics code for clarity and performance#9
Conversation
- Update `engine.rs` to improve readability by using `is_some()` in stream processing loops. - Add `#[must_use]` attribute to `new`, `with_event_channel_capacity`, and `with_action_channel_capacity` methods for better API usage guidance. - Enhance error logging in the `run` method and ensure consistent formatting in error messages. - Implement default constructors for `Metrics` in both `metrics.rs` and `metrics_stub.rs`. - Adjust assertions in tests for clarity and consistency.
- Remove deprecated `publish.yml` workflow and consolidate release steps into a new `release.yml` workflow. - Update `pr_checks.yml` by removing the version check job to streamline CI processes. - Introduce a new `release.yml` that handles version bumping, tagging, and publishing to crates.io using `cargo-release`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
engine.rsto improve readability by usingis_some()in stream processing loops.#[must_use]attribute tonew,with_event_channel_capacity, andwith_action_channel_capacitymethods for better API usage guidance.runmethod and ensure consistent formatting in error messages.Metricsin bothmetrics.rsandmetrics_stub.rs.