Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed inout to a classstructure #33

Merged
merged 4 commits into from
Sep 23, 2024
Merged

changed inout to a classstructure #33

merged 4 commits into from
Sep 23, 2024

Conversation

Olthoff231381
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 83.78378% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.09%. Comparing base (b67c25f) to head (1b8ec76).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mailcom/parse.py 11.11% 8 Missing ⚠️
mailcom/inout.py 88.88% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #33      +/-   ##
==========================================
- Coverage   71.15%   69.09%   -2.07%     
==========================================
  Files           4        4              
  Lines         156      165       +9     
==========================================
+ Hits          111      114       +3     
- Misses         45       51       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@iulusoy iulusoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the instantiation of the class, staticmethods and re-using the instant for common variables, to generate a more flexible interface. In the future the class will get two main methods that will be accessed by the user/main module, and all others will be hidden, to decrease the level of complexity the user is exposed to. First method: get all files and extract text; second method: write dict data to xml file. Both will be wrappers containing the existing structure as helper methods.

@Olthoff231381 Olthoff231381 reopened this Sep 23, 2024
@Olthoff231381 Olthoff231381 merged commit 95c4add into main Sep 23, 2024
9 of 11 checks passed
@Olthoff231381 Olthoff231381 deleted the classStructure branch September 23, 2024 13:26
Copy link

sonarcloud bot commented Sep 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants