Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filesize limits to settings #67

Merged
merged 1 commit into from
Jan 2, 2025
Merged

Add filesize limits to settings #67

merged 1 commit into from
Jan 2, 2025

Conversation

lkeegan
Copy link
Member

@lkeegan lkeegan commented Jan 2, 2025

  • add to Settings
    • max_filesize_h5_mb = 50
    • max_filesize_csv_mb = 10
  • admin interface sliders to select values in range 1-100
  • note there is also a hard-coded upload limit in nginx.conf, currently set to 100mb
  • resolves add file size limits to admin interface #60

@lkeegan
Add filesize limits to settings
dc1e266 
- add to Settings
  - max_filesize_h5_mb = 50
  - max_filesize_csv_mb = 10
- admin interface sliders to select values in range 1-100
- note there is also a hard-coded upload limit in nginx.conf, currently set to 100mb
- resolves #60
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.16%. Comparing base (2b0054d) to head (dc1e266).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #67      +/-   ##
==========================================
+ Coverage   78.10%   78.16%   +0.06%     
==========================================
  Files           8        8              
  Lines         717      719       +2     
==========================================
+ Hits          560      562       +2     
  Misses        157      157

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkeegan lkeegan merged commit d166efb into main Jan 2, 2025
5 checks passed
@lkeegan lkeegan deleted the fix_60_filesize_limits_in_settings branch January 2, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add file size limits to admin interface
2 participants
@lkeegan @codecov-commenter