Add CSV file upload #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkeegan
force-pushed
the
fix_3_csv_file_upload
branch
2 times, most recently
from
06cfb84 to
d869e3b
Compare
- replace single zip file upload with two file uploads: one h5 file, one csv file - replace `/input_file` endpoint with `/input_h5_file` and `/input_csv_file` - update model, endpoints and runner accordingly - validate csv file on frontend - parse first line and extract column names - require that "barcode", "cdr3", "chain" are present - resolves #3 - validate file sizes - h5 must be less than 50MB - csv must be less than 10MB - resolves #2 - increase nginx/flask body limit to 100MB - make runner into a package, add initial test using requests-mock
lkeegan
force-pushed
the
fix_3_csv_file_upload
branch
from
d869e3b to
65a2e8c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/input_fileendpoint with/input_h5_fileand/input_csv_file