-
-
Notifications
You must be signed in to change notification settings - Fork 960
CI: add Windows Integration Tests for .NET #1704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
How about adding some filters |
I would be OK with that. We could also run these in parallel to the .NET Framework tests. There is one test failure though, no idea about that one.
|
I can reproduce the test failure locally on linux when running the net9.0 tests multiple times against the same SSH server container. Recreating the SSH container fixes it. So this appears to be caused by some left over state in the SSH server from the previous run. Shouldn't we run these in in separate jobs in CI anyway? Then they would use their own SSH containers and run in parallel which would speed things up significantly. There is obviously some kind of issue in the tests though either way. I will try to narrow it down further... |
Yeah, they should be separate legs. Thanks for digging in |
so they run in parallel and we avoid the Common_CreateMoreChannelsThanMaxSessions test failure.
this fixes a test failure in Common_CreateMoreChannelsThanMaxSessions when running the tests multiple times against the same SSH server instance. see sshnet#1704 (comment)
Opened #1710 to fix the test failure. |
this fixes a test failure in Common_CreateMoreChannelsThanMaxSessions when running the tests multiple times against the same SSH server instance. see sshnet#1704 (comment)
turns out this is caused by DNS resolution taking about 2 seconds on every new connection...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
see #1702 (comment)