Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Use uv for all pip installs #365

Merged
merged 1 commit into from
May 1, 2024
Merged

ci: Use uv for all pip installs #365

merged 1 commit into from
May 1, 2024

Conversation

matthewfeickert
Copy link
Contributor

@matthewfeickert matthewfeickert commented May 1, 2024 •
edited
Loading

  • Use 'uv pip' for all calls to 'pip install' in GitHub Actions workflows.
  • The '--system' call is required as uv requires a virtual environment to be activated without it, and GitHub Actions does not provide a default virtual environment.

@matthewfeickert
ci: Use uv for all pip installs
fce4435 
* Use 'uv pip' for all calls to 'pip install' in GitHub Actions workflows.
   - c.f. https://github.com/astral-sh/uv/
* The '--system' call is required as uv requires a virtual environment to be
  activated without it, and GitHub Actions does not provide a default virtual
  environment.
@matthewfeickert
Copy link
Contributor Author

cc @BenGalewsky for review.

@BenGalewsky BenGalewsky self-requested a review May 1, 2024 16:07
BenGalewsky
BenGalewsky approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@BenGalewsky BenGalewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you recommend this, then I'm trying it out!

@BenGalewsky BenGalewsky merged commit 41fab59 into ssl-hep:3.0_develop May 1, 2024
16 checks passed
@matthewfeickert matthewfeickert deleted the ci/use-uv-to-install branch May 1, 2024 16:12
@matthewfeickert
Copy link
Contributor Author

If you recommend this, then I'm trying it out!

It can have significant time savings, as scikit-hep/pyhf#2444 (comment) isn't even the largest install time drops that I've seen with it. Henry has a bunch more examples, and thanks to him it is also available as an installer option for build (c.f. https://github.com/pypa/build/releases/tag/1.2.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BenGalewsky BenGalewsky BenGalewsky approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthewfeickert @BenGalewsky