Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Platform part 2 #1049

Merged
merged 505 commits into from
Jan 9, 2024
Merged

Platform part 2 #1049

merged 505 commits into from
Jan 9, 2024

Conversation

k2xl
Copy link
Collaborator

@k2xl k2xl commented Nov 29, 2023

No description provided.

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

Attention: 204 lines in your changes are missing coverage. Please review.

Comparison is base (8bbc582) 80.52% compared to head (8bf3427) 84.10%.

Files Patch % Lines
pages/[subdomain]/leaderboards/index.tsx 0.00% 21 Missing and 1 partial ⚠️
pages/api/internal-jobs/worker/index.ts 64.70% 18 Missing ⚠️
pages/[subdomain]/admin/index.tsx 0.00% 15 Missing ⚠️
pages/api/admin/index.ts 25.00% 15 Missing ⚠️
pages/[subdomain]/match/[matchId]/index.tsx 0.00% 13 Missing ⚠️
lib/appSocketToClient.ts 64.70% 12 Missing ⚠️
lib/dbConnect.ts 61.29% 12 Missing ⚠️
helpers/validators/isComplete.ts 23.07% 9 Missing and 1 partial ⚠️
pages/[subdomain]/ranked/index.tsx 0.00% 7 Missing and 2 partials ⚠️
helpers/getMobileNotification.ts 38.46% 8 Missing ⚠️
... and 28 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
+ Coverage   80.52%   84.10%   +3.57%     
==========================================
  Files         207      221      +14     
  Lines        6194     6252      +58     
  Branches     1374     1325      -49     
==========================================
+ Hits         4988     5258     +270     
+ Misses       1151      955     -196     
+ Partials       55       39      -16     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

{/* eslint-disable-next-line @next/next/no-img-element */}
<img src='https://i.imgur.com/fD1SUrZ.png' alt='Pathology' />
<GameLogoAndLabel id={game.id} gameId={game.id} />
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested but there is a high chance this won't work, email html is very limited

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested! It seems to work

@k2xl k2xl merged commit 7c79f1a into main Jan 9, 2024
13 checks passed
@k2xl k2xl deleted the platform_part_2 branch January 9, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants