Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Configurable browser policy #62

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Conversation

toinevk
Copy link

@toinevk toinevk commented Jun 3, 2017

Add Configurable browser policy & update demo to provide example

PEM-- and others added 2 commits May 17, 2017 13:57
Add Configurable browser policy & update demo to provide example
@PEM--
Copy link
Member

PEM-- commented Jun 3, 2017

Thanks @toinevk

Some remarks before I can merge your contribution:

  • This enhancement is targeted for 3.0.0, it should be on the development branch instead of the master one. We are following git flow branching model.
  • You should pass down an helmet object instead of a manually configured one. This way, package user are able to directly follow helmet's docs.
  • The former behavior was to always have these securities setup. With your PR, package users that haven't configured helmetends up having none, which is bad.

@toinevk toinevk changed the base branch from master to develop June 3, 2017 10:28
@toinevk
Copy link
Author

toinevk commented Jun 3, 2017

Thanks @PEM-- , hopefully I have addressed your concerns. In terms of your last point, I intentionally left default express call in create router and it will only be overridden if the user choses to pass an helmet object. Hope that makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants