fix nil pointer dereference in handleShareRemoved function

ssvlabs · Aug 28, 2024 · f54a9a4 · f54a9a4
1 parent 55dae0a
commit f54a9a4
Showing 1 changed file with 5 additions and 3 deletions.
diff --git a/registry/storage/validatorstore.go b/registry/storage/validatorstore.go
@@ -293,9 +293,11 @@ func (c *validatorStore) handleShareRemoved(pk spectypes.ValidatorPK) {
 	}
 
 	// Update byValidatorIndex
-	c.muValidatorIndex.Lock()
-	delete(c.byValidatorIndex, share.BeaconMetadata.Index)
-	c.muValidatorIndex.Unlock()
+	if share.BeaconMetadata != nil {
+		c.muValidatorIndex.Lock()
+		delete(c.byValidatorIndex, share.BeaconMetadata.Index)
+		c.muValidatorIndex.Unlock()
+	}
 
 	// Update byCommitteeID
 	committeeID := share.CommitteeID()