Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

♻️ refactor rspec files #48

Merged
merged 2 commits into from
Nov 3, 2024
Merged

♻️ refactor rspec files #48

merged 2 commits into from
Nov 3, 2024

Conversation

byplayer
Copy link
Contributor

@byplayer byplayer commented Nov 2, 2024

I will implement shared_context and shared_examples in the future. Before that, I would like to refactor rspec files to map library files to rspec files.

This structure is supported by rspec-mode of emacs or "rails go to spec" plugin of vscode.

@byplayer
♻️ refactor rspec files
04ac39b 
I will implement shared_context, shared_examples in the future.
Before that, I would like to refactor rspec files to map library
files to rspec files.

This structure is supported by rspec-mode of emacs or "rails go to
spec" plugin of vscode.
st0012
st0012 reviewed Nov 2, 2024
View reviewed changes
Copy link
Owner

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR and I think splitting specs is a good idea. But I don't feel it's necessary to mimic the nested structure of the actual library code this way. Can we just have spec/[code_lens|definition|document_symbol]_spec.rb?

@byplayer
👍 change rspec file path
9a4c917 
I remove lib directory for rspec to access specs easily.
@byplayer
Copy link
Contributor Author

byplayer commented Nov 3, 2024

@st0012
I understood.
I fix *_spec.rb path.
Could you recheck it?

st0012
st0012 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@st0012 st0012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@st0012 st0012 merged commit 0da0abf into st0012:main Nov 3, 2024
3 checks passed
@byplayer byplayer deleted the refactor_rspec branch November 4, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@st0012 st0012 st0012 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@byplayer @st0012