support queries which acquire read locks (#179)

Co-authored-by: Markus Staab <m.staab@complex-it.de>
staabm · Jan 22, 2022 · 76fea3a · 76fea3a
1 parent 47d8cce
commit 76fea3a
Show file tree

Hide file tree

Showing 5 changed files with 363 additions and 3 deletions.
diff --git a/.phpstan-dba.cache b/.phpstan-dba.cache
diff --git a/.phpunit-phpstan-dba.cache b/.phpunit-phpstan-dba.cache
diff --git a/src/QueryReflection/QuerySimulation.php b/src/QueryReflection/QuerySimulation.php
@@ -112,17 +112,23 @@ public static function simulate(string $queryString): ?string
 
     private static function stripTraillingLimit(string $queryString): ?string
     {
+        // XXX someday we will use a proper SQL parser,
         $queryString = rtrim($queryString, ';');
 
+        // strip trailling FOR UPDATE/FOR SHARE
+        $queryString = preg_replace('/(.*)FOR (UPDATE|SHARE)\s*$/i', '$1', $queryString);
+
+        if (null === $queryString) {
+            throw new ShouldNotHappenException('Could not strip trailling FOR UPDATE/SHARE from query');
+        }
+
         // strip trailling OFFSET
         $queryString = preg_replace('/(.*)OFFSET\s+["\']?\d+["\']?\s*$/i', '$1', $queryString);
 
         if (null === $queryString) {
-            throw new ShouldNotHappenException('Could not strip trailing offset from query');
+            throw new ShouldNotHappenException('Could not strip trailing OFFSET from query');
         }
 
-        // XXX someday we will use a proper SQL parser,
-        // which would also allow us to support even more complex expressions like SELECT .. LIMIT X, Y FOR UPDATE
         return preg_replace('/\s*LIMIT\s+["\']?\d+["\']?\s*(,\s*["\']?\d*["\']?)?\s*$/i', '', $queryString);
     }
 }